#9191 mass energy eqivalence #9217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Einstein's Mass-Energy Equivalence E=MC^2
Einstein's Mass-Energy Equivalence E=MC^2 #9191
feature#9191
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
CaedenPH
requested changes
Oct 1, 2023
tianyizheng02
requested changes
Oct 1, 2023
physics/mass_energy_equivalence.py
Outdated
Comment on lines
30
to
33
| # Calculate energy using the equation E=mc^2 | ||
| energy = mass * m.pow(speed_of_light, 2) | ||
| # return value has unit Joules | ||
| return energy |
There was a problem hiding this comment.
Instead of having comments explain each line, please explain the equation and the input and output types in the function docstring
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
for more information, see https://pre-commit.ci
mhsuhail00
commented
Oct 1, 2023
for more information, see https://pre-commit.ci
mhsuhail00
commented
Oct 1, 2023
mhsuhail00
commented
Oct 1, 2023
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
for more information, see https://pre-commit.ci
tianyizheng02
requested changes
Oct 2, 2023
tianyizheng02
requested changes
Oct 2, 2023
Comment on lines
+10
to
+11
| The function takes a single argument mass(in kg) having datatype float and | ||
| returns the energy(in joule) having datatype float |
There was a problem hiding this comment.
This is a description of the function, so please put it in the function's docstring rather than the header string.
Comment on lines
+5
to
+8
| Here it defines a Function to calculate energy(in joules) equivalent of a given | ||
| mass(in kilograms) using Einstein's Mass-energy equivalence equation E=mc^2 | ||
| where m is mass and c = 299,792,458 meter per second is the speed of light | ||
| in vacuum (a constant value). |
There was a problem hiding this comment.
Suggested change
| Here it defines a Function to calculate energy(in joules) equivalent of a given | |
| mass(in kilograms) using Einstein's Mass-energy equivalence equation E=mc^2 | |
| where m is mass and c = 299,792,458 meter per second is the speed of light | |
| in vacuum (a constant value). | |
| This file defines a function to calculate energy (in joules) equivalent to a given | |
| mass (in kilograms) using Einstein's mass-energy equivalence equation E=mc^2, | |
| where m is mass and c = 299,792,458 m/s is the speed of light in a vacuum. |
Fixes for grammar, formatting, and wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Feature #9191
I have added a module to calculate energy equivalence by mass. Taking mass in kilograms and giving result in Joules.
the function names calculate_energy() which returns a floating value.
Checklist: